Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15315 )
Change subject: [java] subprocess: add a metrics message ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15315/1/src/kudu/subprocess/subprocess.proto File src/kudu/subprocess/subprocess.proto: http://gerrit.cloudera.org:8080/#/c/15315/1/src/kudu/subprocess/subprocess.proto@49 PS1, Line 49: // Number of requests in the subprocess's inbound queue. : optional int64 inbound_queue_length = 3; : : // Number of responses in the subprocess's outbound queue. : optional int64 outbound_queue_length = 4; > To get a gauge what the current state of the queues are in general, "as late > as we can before sending back to C++" is useful. Not following the intuition here: doesn't _any_ point in time yield "the current state of the queues", as long as the point in time is consistently applied (i.e. always measure at enqueue time)? > Do you think it's worth adding both? A snapshot upon entering the system and > a snapshot upon exiting the system? Or is that overkill and wasteful? I think that's overkill, at least for now. We can always revisit it in the future. -- To view, visit http://gerrit.cloudera.org:8080/15315 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11a89fff8df23c5057c577f2aebfd40922d01e3c Gerrit-Change-Number: 15315 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 28 Feb 2020 22:52:58 +0000 Gerrit-HasComments: Yes
