Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15315 )
Change subject: [java] subprocess: add a metrics message ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15315/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessMetrics.java File java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessMetrics.java: http://gerrit.cloudera.org:8080/#/c/15315/2/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessMetrics.java@77 PS2, Line 77: reset > So this seems there is an order assumption about calling recordInboundQueue Not really. I don't think it'd add anything to what's already documented. -- To view, visit http://gerrit.cloudera.org:8080/15315 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I11a89fff8df23c5057c577f2aebfd40922d01e3c Gerrit-Change-Number: 15315 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 03 Mar 2020 01:30:55 +0000 Gerrit-HasComments: Yes
