Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15344 )
Change subject: subprocess: plumb Java metrics into C++ ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/15344/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15344/1//COMMIT_MSG@11 PS1, Line 11: SubprossProxy SubprocessProxy? http://gerrit.cloudera.org:8080/#/c/15344/1/src/kudu/subprocess/echo_subprocess.h File src/kudu/subprocess/echo_subprocess.h: PS1: Agreed with Tidy Bot: if this file is all metric definitions, why is it a header? http://gerrit.cloudera.org:8080/#/c/15344/1/src/kudu/subprocess/echo_subprocess.h@58 PS1, Line 58: GINIT(inbound_queue_length, echo_subprocess_inbound_queue_length); : GINIT(outbound_queue_length, echo_subprocess_outbound_queue_length); Don't want to use histograms for these? http://gerrit.cloudera.org:8080/#/c/15344/1/src/kudu/subprocess/subprocess_proxy.h File src/kudu/subprocess/subprocess_proxy.h: http://gerrit.cloudera.org:8080/#/c/15344/1/src/kudu/subprocess/subprocess_proxy.h@60 PS1, Line 60: std::unique_ptr<google::protobuf::Any> packed_req(new google::protobuf::Any); : packed_req->PackFrom(req); : sreq.set_allocated_request(packed_req.release()); Could you do this instead? sreq.mutable_request()->PackFrom(req); -- To view, visit http://gerrit.cloudera.org:8080/15344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7260ea13717dfd4af0138f77dfb6e5d239b3bee2 Gerrit-Change-Number: 15344 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 03 Mar 2020 06:48:46 +0000 Gerrit-HasComments: Yes
