Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15344 )
Change subject: subprocess: plumb Java metrics into C++ ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Thanks for the patch! Just some nits. And the IWYU error needs to be addressed. http://gerrit.cloudera.org:8080/#/c/15344/3/src/kudu/subprocess/subprocess_proxy.h File src/kudu/subprocess/subprocess_proxy.h: http://gerrit.cloudera.org:8080/#/c/15344/3/src/kudu/subprocess/subprocess_proxy.h@45 PS3, Line 45: class SubprocessProxy nit: Can you add a description for this class? http://gerrit.cloudera.org:8080/#/c/15344/3/src/kudu/subprocess/subprocess_proxy.h@66 PS3, Line 66: ("" We don't need to add any information about this error here? -- To view, visit http://gerrit.cloudera.org:8080/15344 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7260ea13717dfd4af0138f77dfb6e5d239b3bee2 Gerrit-Change-Number: 15344 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 03 Mar 2020 21:12:47 +0000 Gerrit-HasComments: Yes
