Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15074 )
Change subject: [java] KUDU-2972: Add Kudu Ranger plugin ...................................................................... Patch Set 18: (4 comments) http://gerrit.cloudera.org:8080/#/c/15074/13/java/kudu-ranger/src/main/java/org/apache/kudu/ranger/authorization/RangerKuduAuthorizer.java File java/kudu-ranger/src/main/java/org/apache/kudu/ranger/authorization/RangerKuduAuthorizer.java: http://gerrit.cloudera.org:8080/#/c/15074/13/java/kudu-ranger/src/main/java/org/apache/kudu/ranger/authorization/RangerKuduAuthorizer.java@115 PS13, Line 115: > nit: capitalize Done http://gerrit.cloudera.org:8080/#/c/15074/13/java/kudu-ranger/src/main/java/org/apache/kudu/ranger/authorization/RangerKuduAuthorizer.java@120 PS13, Line 120: > nit: "who is performing" Done http://gerrit.cloudera.org:8080/#/c/15074/13/java/kudu-ranger/src/test/java/org/apache/kudu/ranger/TestRangerSubprocess.java File java/kudu-ranger/src/test/java/org/apache/kudu/ranger/TestRangerSubprocess.java: http://gerrit.cloudera.org:8080/#/c/15074/13/java/kudu-ranger/src/test/java/org/apache/kudu/ranger/TestRangerSubprocess.java@128 PS13, Line 128: : : : : : : : : > nit: consider reusing setUpExecutorIO() form TestEchoSubprocess? Maybe put Done http://gerrit.cloudera.org:8080/#/c/15074/13/java/kudu-ranger/src/test/java/org/apache/kudu/ranger/TestRangerSubprocess.java@137 PS13, Line 137: : : : : : : > It isn't really clear why we're timing out here, given we successfully get Done -- To view, visit http://gerrit.cloudera.org:8080/15074 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c995ac1a48ebf57667231cd3a82d3794f6ddf8d Gerrit-Change-Number: 15074 Gerrit-PatchSet: 18 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 04 Mar 2020 19:30:55 +0000 Gerrit-HasComments: Yes
