Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15074 )
Change subject: [java] KUDU-2972: Add Kudu Ranger plugin ...................................................................... Patch Set 19: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/15074/19/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ProtocolHandler.java File java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ProtocolHandler.java: http://gerrit.cloudera.org:8080/#/c/15074/19/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ProtocolHandler.java@47 PS19, Line 47: public nit: this can remain private, right? http://gerrit.cloudera.org:8080/#/c/15074/19/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/RangerSubprocessMain.java File java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/RangerSubprocessMain.java: http://gerrit.cloudera.org:8080/#/c/15074/19/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/ranger/RangerSubprocessMain.java@22 PS19, Line 22: : @InterfaceAudience.Private : class RangerSubprocessMain { : : public static void main(String[] args) throws Exception { : SubprocessExecutor subprocessExecutor = new SubprocessExecutor(); : RangerProtocolHandler protocolProcessor = new RangerProtocolHandler(); : subprocessExecutor.run(args, protocolProcessor, /* timeoutMs= */-1); : } : } nit: Do you also think it's worth describing what configuration is required to run this class? What needs to be on the class path? What config files are needed? http://gerrit.cloudera.org:8080/#/c/15074/19/src/kudu/ranger/CMakeLists.txt File src/kudu/ranger/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/15074/19/src/kudu/ranger/CMakeLists.txt@33 PS19, Line 33: wire_protocol_proto I think this was required for subprocess.proto for AppStatusPB, but we don't have that in ranger.proto. Do we still need it? -- To view, visit http://gerrit.cloudera.org:8080/15074 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c995ac1a48ebf57667231cd3a82d3794f6ddf8d Gerrit-Change-Number: 15074 Gerrit-PatchSet: 19 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 04 Mar 2020 21:21:02 +0000 Gerrit-HasComments: Yes
