Hello Attila Bukor, Hao Hao,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/15362
to review the following change.
Change subject: [wip] subprocess: fix TestEchoSubprocess
......................................................................
[wip] subprocess: fix TestEchoSubprocess
There were a number of issues with TestEchoSubprocess:
- Many tests coarsely expected timeouts, leading to the non-execution of
many parts of the test. Instead, I wrapped executor.run() with a
executor.runUntilTimeout() that expects the timeout, rather than
relying on test-level expectation of timeouts.
- Initializing BufferedInputStream with the same pipe multiple times led
to us to miss out on some bytes in the pipe. This initializes the
BufferedInputStream once as a member.
- testMsgWithEmptyMessage() wouldn't time out because its readers were
stuck parsing an empty pipe. This is resolved by adding more requests
to the pipe.
wip: rebase on https://gerrit.cloudera.org/c/15074/
Change-Id: I351ae84285fa5eb9db5dcc374dd404e475a9ddb4
---
M
java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java
M
java/kudu-subprocess/src/test/java/org/apache/kudu/subprocess/echo/TestEchoSubprocess.java
2 files changed, 46 insertions(+), 21 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/15362/1
--
To view, visit http://gerrit.cloudera.org:8080/15362
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I351ae84285fa5eb9db5dcc374dd404e475a9ddb4
Gerrit-Change-Number: 15362
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
