Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15362 )
Change subject: subprocess: fix TestEchoSubprocess ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/15362/1/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java File java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java: http://gerrit.cloudera.org:8080/#/c/15362/1/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java@36 PS1, Line 36: import com.google.common.base.Preconditions; > Nit: Avoid * import. You may need to tell Intellij not to do this by settin Ugh. Yeah. http://gerrit.cloudera.org:8080/#/c/15362/1/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java@36 PS1, Line 36: import com.google.common.base.Preconditions; > +1 Done -- To view, visit http://gerrit.cloudera.org:8080/15362 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I351ae84285fa5eb9db5dcc374dd404e475a9ddb4 Gerrit-Change-Number: 15362 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 05 Mar 2020 03:27:55 +0000 Gerrit-HasComments: Yes
