Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15366 )
Change subject: subprocess: report metrics even when calls fail ...................................................................... subprocess: report metrics even when calls fail This moves metric reporting for metrics returned by the subprocess into the SubprocessServer so they are still reported in the event that the call fails. To do this, I moved the SubprocessMetrics into the SubprocessServer, which means that these metrics are now required by the server. As such, I moved the declarations of Echo metrics out of subprocess_proxy-test so they could be reused by other tests. This should prove more useful, particularly given the fact that failed calls warrant a deeper look at these metrics. Change-Id: I87cc82f82a0a767383284799ec6159d680526ea9 Reviewed-on: http://gerrit.cloudera.org:8080/15366 Reviewed-by: Adar Dembo <a...@cloudera.com> Tested-by: Andrew Wong <aw...@cloudera.com> --- M src/kudu/ranger/ranger_client-test.cc M src/kudu/subprocess/CMakeLists.txt A src/kudu/subprocess/echo_subprocess.cc A src/kudu/subprocess/echo_subprocess.h M src/kudu/subprocess/server.cc M src/kudu/subprocess/server.h M src/kudu/subprocess/subprocess_proxy-test.cc M src/kudu/subprocess/subprocess_proxy.h M src/kudu/subprocess/subprocess_server-test.cc 9 files changed, 198 insertions(+), 91 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Andrew Wong: Verified -- To view, visit http://gerrit.cloudera.org:8080/15366 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I87cc82f82a0a767383284799ec6159d680526ea9 Gerrit-Change-Number: 15366 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
