Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15366 )
Change subject: subprocess: report metrics even when calls fail ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15366/3/src/kudu/subprocess/server.cc File src/kudu/subprocess/server.cc: http://gerrit.cloudera.org:8080/#/c/15366/3/src/kudu/subprocess/server.cc@226 PS3, Line 226: This check is conservative; we always expect metrics. > You could replace this with a PREDICT_TRUE, which will inform the CPU's bra Done -- To view, visit http://gerrit.cloudera.org:8080/15366 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I87cc82f82a0a767383284799ec6159d680526ea9 Gerrit-Change-Number: 15366 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 05 Mar 2020 05:56:33 +0000 Gerrit-HasComments: Yes