Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15373 )
Change subject: [util] Import "Or" function to BlockBloomFilter from Impala ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/15373/1/src/kudu/util/block_bloom_filter.h File src/kudu/util/block_bloom_filter.h: http://gerrit.cloudera.org:8080/#/c/15373/1/src/kudu/util/block_bloom_filter.h@161 PS1, Line 161: static constexpr BlockBloomFilter* const kAlwaysTrueFilter = nullptr; Does this need to be public? Why? http://gerrit.cloudera.org:8080/#/c/15373/1/src/kudu/util/block_bloom_filter.cc File src/kudu/util/block_bloom_filter.cc: http://gerrit.cloudera.org:8080/#/c/15373/1/src/kudu/util/block_bloom_filter.cc@50 PS1, Line 50: constexpr BlockBloomFilter* const BlockBloomFilter::kAlwaysTrueFilter; Does this need to be initialized to something meaningful? In the header it's null; is that intentional? http://gerrit.cloudera.org:8080/#/c/15373/1/src/kudu/util/block_bloom_filter.cc@292 PS1, Line 292: reinterpret_cast<uint8_t*>(other.directory_) Nit: push this to the next line so the symmetry with the second reinterpret_cast is more obvious? -- To view, visit http://gerrit.cloudera.org:8080/15373 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5f9311f73dcff883dd2cce18fd558e7d57d14f Gerrit-Change-Number: 15373 Gerrit-PatchSet: 1 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 05 Mar 2020 23:31:56 +0000 Gerrit-HasComments: Yes
