Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15373 )
Change subject: [util] Import "Or" function to BlockBloomFilter from Impala ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15373/3/src/kudu/util/block_bloom_filter.cc File src/kudu/util/block_bloom_filter.cc: http://gerrit.cloudera.org:8080/#/c/15373/3/src/kudu/util/block_bloom_filter.cc@296 PS3, Line 296: CHECK_NE > BTW, why not to use the same approach as with difference in directory size For the reasons mentioned in the comment above. // Moreover for a reference "other" to be an AlwaysTrueFilter the reference needs // to be created from a nullptr and so we get into undefined behavior territory. // Comparing AlwaysTrueFilter with "&other" results in a compiler warning for // comparing a non-null argument "other" with NULL [-Wnonnull-compare]. -- To view, visit http://gerrit.cloudera.org:8080/15373 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5f9311f73dcff883dd2cce18fd558e7d57d14f Gerrit-Change-Number: 15373 Gerrit-PatchSet: 3 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 10 Mar 2020 17:51:35 +0000 Gerrit-HasComments: Yes
