Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15374 )
Change subject: [WIP] Mini Ranger + Postgres ...................................................................... Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/15374/1/src/kudu/ranger/mini_ranger.h File src/kudu/ranger/mini_ranger.h: http://gerrit.cloudera.org:8080/#/c/15374/1/src/kudu/ranger/mini_ranger.h@46 PS1, Line 46: int int16_t ? http://gerrit.cloudera.org:8080/#/c/15374/1/src/kudu/ranger/mini_ranger.h@46 PS1, Line 46: ; const? http://gerrit.cloudera.org:8080/#/c/15374/1/src/kudu/ranger/mini_ranger.h@48 PS1, Line 48: std::unique_ptr<Subprocess> postgres_process_; > error: no template named 'unique_ptr' in namespace 'std' [clang-diagnostic- apparently <memory> header is missing http://gerrit.cloudera.org:8080/#/c/15374/1/src/kudu/ranger/mini_ranger.cc File src/kudu/ranger/mini_ranger.cc: http://gerrit.cloudera.org:8080/#/c/15374/1/src/kudu/ranger/mini_ranger.cc@146 PS1, Line 146: max_connections = 100 Is this the default? If yes, then why is it necessary to add it in here? http://gerrit.cloudera.org:8080/#/c/15374/1/src/kudu/ranger/mini_ranger.cc@152 PS1, Line 152: lc_messages = 'en_US.UTF-8' # locale for system error message : lc_monetary = 'en_US.UTF-8' # locale for monetary formatting : lc_numeric = 'en_US.UTF-8' # locale for number formatting : lc_time = 'en_US.UTF-8' # locale for time formatting Probably, the defaults are good enough, why to add these? http://gerrit.cloudera.org:8080/#/c/15374/1/src/kudu/ranger/mini_ranger.cc@369 PS1, Line 369: BindAndListen Maybe, Bind() is enough? http://gerrit.cloudera.org:8080/#/c/15374/1/src/kudu/ranger/mini_ranger.cc@372 PS1, Line 372: listener.Close(); nit: this is not needed since the destructor of the Socket does that -- To view, visit http://gerrit.cloudera.org:8080/15374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba40126aa60e0ecbc5ae10cc1328493194c345bc Gerrit-Change-Number: 15374 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Anonymous Coward (314) Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 06 Mar 2020 09:23:13 +0000 Gerrit-HasComments: Yes
