Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15374 )
Change subject: KUDU-3079 Add MiniRanger pt 1 ...................................................................... Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/15374/1/src/kudu/ranger/mini_ranger.h File src/kudu/ranger/mini_ranger.h: http://gerrit.cloudera.org:8080/#/c/15374/1/src/kudu/ranger/mini_ranger.h@46 PS1, Line 46: C > const? made it static http://gerrit.cloudera.org:8080/#/c/15374/1/src/kudu/ranger/mini_ranger.h@46 PS1, Line 46: Sta > int16_t ? Done http://gerrit.cloudera.org:8080/#/c/15374/1/src/kudu/ranger/mini_ranger.h@48 PS1, Line 48: static int16_t GetRandomPort(); > apparently <memory> header is missing Done http://gerrit.cloudera.org:8080/#/c/15374/1/src/kudu/ranger/mini_ranger.cc File src/kudu/ranger/mini_ranger.cc: http://gerrit.cloudera.org:8080/#/c/15374/1/src/kudu/ranger/mini_ranger.cc@146 PS1, Line 146: max_connections = 100 > Is this the default? If yes, then why is it necessary to add it in here? initdb creates this config file by default, I pasted it to the template as we need to rewrite the port manually. http://gerrit.cloudera.org:8080/#/c/15374/1/src/kudu/ranger/mini_ranger.cc@152 PS1, Line 152: lc_messages = 'en_US.UTF-8' # locale for system error message : lc_monetary = 'en_US.UTF-8' # locale for monetary formatting : lc_numeric = 'en_US.UTF-8' # locale for number formatting : lc_time = 'en_US.UTF-8' # locale for time formatting > Probably, the defaults are good enough, why to add these? same as above http://gerrit.cloudera.org:8080/#/c/15374/1/src/kudu/ranger/mini_ranger.cc@369 PS1, Line 369: Bind(address) > Maybe, Bind() is enough? Done http://gerrit.cloudera.org:8080/#/c/15374/1/src/kudu/ranger/mini_ranger.cc@372 PS1, Line 372: > nit: this is not needed since the destructor of the Socket does that Done -- To view, visit http://gerrit.cloudera.org:8080/15374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba40126aa60e0ecbc5ae10cc1328493194c345bc Gerrit-Change-Number: 15374 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Anonymous Coward (314) Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 18 Mar 2020 21:36:42 +0000 Gerrit-HasComments: Yes
