Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15307 )
Change subject: [tserver] report the newly bootstrapped tablet after OpenTablet completes ...................................................................... Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/15307/14/src/kudu/integration-tests/ts_tablet_manager-itest.cc File src/kudu/integration-tests/ts_tablet_manager-itest.cc: http://gerrit.cloudera.org:8080/#/c/15307/14/src/kudu/integration-tests/ts_tablet_manager-itest.cc@920 PS14, Line 920: if (!AllowSlowTests()) { : LOG(WARNING) << "test is skipped; set KUDU_ALLOW_SLOW_TESTS=1 to run"; : return; : } New tests should use the SKIP_IF_SLOW_NOT_ALLOWED macro. http://gerrit.cloudera.org:8080/#/c/15307/14/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/15307/14/src/kudu/tserver/ts_tablet_manager.cc@1179 PS14, Line 1179: if (PREDICT_TRUE(FLAGS_delete_tablet_from_transition_map_explicitly)) { I don't think this makes sense; it's effectively a gflag that, when off, regresses a bug. That's pretty different than other test-only gflags that e.g. inject latency, which could conceivably happen in real life. Instead of doing this, just show (in your commit description or whatever) that if you run the new test _without_ the fix, it fails. With the fix, obviously, it should pass. -- To view, visit http://gerrit.cloudera.org:8080/15307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I591dc8daceb81f9e800098be77c928d391cdc00a Gerrit-Change-Number: 15307 Gerrit-PatchSet: 14 Gerrit-Owner: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Comment-Date: Sun, 08 Mar 2020 22:14:08 +0000 Gerrit-HasComments: Yes
