Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15307 )
Change subject: [tserver] report the newly bootstrapped tablet after OpenTablet completes ...................................................................... Patch Set 11: (2 comments) I don't think the test failures are related to your change. Alexey, could you review the change in usage to MarkTabletDirty? Is it safe? Can you think of any situations where we now may miss an important full tablet report to the master? http://gerrit.cloudera.org:8080/#/c/15307/11/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/15307/11/src/kudu/tserver/ts_tablet_manager.cc@1646 PS11, Line 1646: void TransitionInProgressDeleter::destroy() { Should call it Destroy() http://gerrit.cloudera.org:8080/#/c/15307/11/src/kudu/tserver/ts_tablet_manager.cc@1655 PS11, Line 1655: std::lock_guard<RWMutex> lock(*lock_); : CHECK(in_progress_->erase(entry_)); You can replace this with a call to destroy(). -- To view, visit http://gerrit.cloudera.org:8080/15307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I591dc8daceb81f9e800098be77c928d391cdc00a Gerrit-Change-Number: 15307 Gerrit-PatchSet: 11 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Wed, 04 Mar 2020 17:49:42 +0000 Gerrit-HasComments: Yes
