Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15372 )
Change subject: [util] Add support for 32 & 64 byte alignment to Arena allocator ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15372/3/src/kudu/util/memory/arena.h File src/kudu/util/memory/arena.h: http://gerrit.cloudera.org:8080/#/c/15372/3/src/kudu/util/memory/arena.h@415 PS3, Line 415: // Component start address "data_" is only guaranteed to be 16-byte aligned with enough : // bytes for the first request size plus any padding needed for alignment. : // So to support alignment values greater than 16 bytes, align the destination address ptr : // that'll be returned to the caller and not just the "offset_". > Nit: could you move this up to the definition of AlignOffset, so it's clear Done -- To view, visit http://gerrit.cloudera.org:8080/15372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib665115fa0fc262a8b76c48f52947dedb84be2a7 Gerrit-Change-Number: 15372 Gerrit-PatchSet: 3 Gerrit-Owner: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 09 Mar 2020 22:47:29 +0000 Gerrit-HasComments: Yes
