Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15372 )
Change subject: [util] Add support for 32 & 64 byte alignment to Arena allocator ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/15372/4/src/kudu/util/memory/arena.h File src/kudu/util/memory/arena.h: http://gerrit.cloudera.org:8080/#/c/15372/4/src/kudu/util/memory/arena.h@406 PS4, Line 406: // Adjusts the supplied "offset" such that the combined "data" ptr and "offset" aligns : // with "alignment" bytes. : template<typename T> : inline T AlignOffset(const uint8_t* data, const T offset, const size_t alignment) { : const auto data_start_addr = reinterpret_cast<uintptr_t>(data); : return KUDU_ALIGN_UP((data_start_addr + offset), alignment) - data_start_addr; : } > Did you mean to duplicate this? Nope. -- To view, visit http://gerrit.cloudera.org:8080/15372 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib665115fa0fc262a8b76c48f52947dedb84be2a7 Gerrit-Change-Number: 15372 Gerrit-PatchSet: 4 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 09 Mar 2020 22:54:11 +0000 Gerrit-HasComments: Yes
