Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15393 )
Change subject: [docker] Add an Impala quickstart image ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/15393/1/docker/Dockerfile File docker/Dockerfile: http://gerrit.cloudera.org:8080/#/c/15393/1/docker/Dockerfile@419 PS1, Line 419: RUN ln -s impalad statestored && ln -s impalad catalogd Doesn't this link both statestored and catalogd to impalad? http://gerrit.cloudera.org:8080/#/c/15393/1/docker/Dockerfile@448 PS1, Line 448: impala-shell Given the Impala version is pegged at 3.3, should this version be fixed too? Or does it not matter much here since it'll likely be backwards compatible anyway? http://gerrit.cloudera.org:8080/#/c/15393/1/docker/Dockerfile@469 PS1, Line 469: An image with the Impala binaries pre-installed. nit: maybe note the Impala version? http://gerrit.cloudera.org:8080/#/c/15393/1/docker/bootstrap-dev-env.sh File docker/bootstrap-dev-env.sh: http://gerrit.cloudera.org:8080/#/c/15393/1/docker/bootstrap-dev-env.sh@62 PS1, Line 62: : # Install exta impala packages for the impala images. They are nominal in size. : # --no-install-recommends keeps the install smaller : apt-get install -y --no-install-recommends \ : libffi-devel \ : lzo-devel \ : tzdata Should be yum? http://gerrit.cloudera.org:8080/#/c/15393/1/docker/bootstrap-runtime-env.sh File docker/bootstrap-runtime-env.sh: http://gerrit.cloudera.org:8080/#/c/15393/1/docker/bootstrap-runtime-env.sh@44 PS1, Line 44: apt-get install -y --no-install-recommends \ : cyrus-sasl-devel \ : lzo-devel \ : tzdata Here too -- To view, visit http://gerrit.cloudera.org:8080/15393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d88bcb52f793c0fc83c4f84a9b56c5b961e58d5 Gerrit-Change-Number: 15393 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 10 Mar 2020 05:42:54 +0000 Gerrit-HasComments: Yes
