Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15393 )
Change subject: [docker] Add an Impala quickstart image ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/15393/1/docker/Dockerfile File docker/Dockerfile: http://gerrit.cloudera.org:8080/#/c/15393/1/docker/Dockerfile@419 PS1, Line 419: WORKDIR $IMPALA_HOME > Doesn't this link both statestored and catalogd to impalad? It does. They are actually all the same binary, so this saves space. http://gerrit.cloudera.org:8080/#/c/15393/1/docker/Dockerfile@448 PS1, Line 448: python-env.s > Given the Impala version is pegged at 3.3, should this version be fixed too It probably should be, though it doesn't matter at the moment. That will be fixed when the above TODO is complete in a follow on I suppose. http://gerrit.cloudera.org:8080/#/c/15393/1/docker/Dockerfile@469 PS1, Line 469: > nit: maybe note the Impala version? I can add the Impala Version as a label below. http://gerrit.cloudera.org:8080/#/c/15393/1/docker/bootstrap-dev-env.sh File docker/bootstrap-dev-env.sh: http://gerrit.cloudera.org:8080/#/c/15393/1/docker/bootstrap-dev-env.sh@62 PS1, Line 62: : # Install exta impala packages for the impala images. They are nominal in size. : # --no-install-recommends keeps the install smaller : yum install -y --no-install-recommends \ : libffi-devel \ : lzo-devel \ : tzdata > Should be yum? Done http://gerrit.cloudera.org:8080/#/c/15393/1/docker/bootstrap-runtime-env.sh File docker/bootstrap-runtime-env.sh: http://gerrit.cloudera.org:8080/#/c/15393/1/docker/bootstrap-runtime-env.sh@44 PS1, Line 44: yum install -y --no-install-recommends \ : cyrus-sasl-devel \ : lzo-devel \ : tzdata > Here too Done -- To view, visit http://gerrit.cloudera.org:8080/15393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d88bcb52f793c0fc83c4f84a9b56c5b961e58d5 Gerrit-Change-Number: 15393 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 10 Mar 2020 14:10:38 +0000 Gerrit-HasComments: Yes
