Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15373 )
Change subject: [util] Import "Or" function to BlockBloomFilter from Impala ...................................................................... [util] Import "Or" function to BlockBloomFilter from Impala Impala will be switching to using the Block Bloom filter from kudu-util. "Or" function was missing and this change adds it. Note that original implementation for OrEqualArrayAvx() in Impala is targeted for AVX and not AVX2, however AVX2 is super-set of AVX instructions and there is already provision in the Block Bloom filter to separate out AVX2 v/s non-AVX2 (SSE) code. Hence don't see need to add separate AVX specific file/implementation. Change-Id: Ibe5f9311f73dcff883dd2cce18fd558e7d57d14f Reviewed-on: http://gerrit.cloudera.org:8080/15373 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/util/block_bloom_filter-test.cc M src/kudu/util/block_bloom_filter.cc M src/kudu/util/block_bloom_filter.h M src/kudu/util/block_bloom_filter_avx2.cc 4 files changed, 134 insertions(+), 3 deletions(-) Approvals: Kudu Jenkins: Verified Adar Dembo: Looks good to me, approved Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/15373 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ibe5f9311f73dcff883dd2cce18fd558e7d57d14f Gerrit-Change-Number: 15373 Gerrit-PatchSet: 4 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
