Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/15396 )
Change subject: [util] Changes to allow serializing/de-serializing BlockBloomFilter to a custom format ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/15396/1/src/kudu/util/block_bloom_filter.cc File src/kudu/util/block_bloom_filter.cc: http://gerrit.cloudera.org:8080/#/c/15396/1/src/kudu/util/block_bloom_filter.cc@134 PS1, Line 134: directory_ > If always_false is true doesn't mean directory size is 0 even with 0 log_sp Then it looks good to me. -- To view, visit http://gerrit.cloudera.org:8080/15396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79504813024abaf452e2c2b244391024b442d6f7 Gerrit-Change-Number: 15396 Gerrit-PatchSet: 1 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 11 Mar 2020 00:21:57 +0000 Gerrit-HasComments: Yes
