Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15396 )
Change subject: [util] Changes to allow serializing/de-serializing BlockBloomFilter to a custom format ...................................................................... [util] Changes to allow serializing/de-serializing BlockBloomFilter to a custom format Consumers of the BlockBloomFilter like Impala would prefer using its own serialization/deserializing message format or library. Hence following set of changes: - InitFromDirectory() that allows initialization from a populated directory structure. - log_space_bytes() and directory() public functions to allow serialization. - Renamed AlwaysFalse() to always_false() since it's a simple get function providing access to data. Change-Id: I79504813024abaf452e2c2b244391024b442d6f7 Reviewed-on: http://gerrit.cloudera.org:8080/15396 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Kudu Jenkins Reviewed-by: Wenzhe Zhou <[email protected]> --- M src/kudu/util/block_bloom_filter-test.cc M src/kudu/util/block_bloom_filter.cc M src/kudu/util/block_bloom_filter.h 3 files changed, 39 insertions(+), 21 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified Wenzhe Zhou: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/15396 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I79504813024abaf452e2c2b244391024b442d6f7 Gerrit-Change-Number: 15396 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
