Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15401 )
Change subject: threadpool: simplify Submit API ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/15401/2/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: http://gerrit.cloudera.org:8080/#/c/15401/2/src/kudu/consensus/consensus_queue.cc@1512 PS2, Line 1512: = > Does it make a difference whether this is 'this' or '='? In this case I don't think it'll have any effect (since 'this' is the only thing that _can_ be captured). And I used '=' so as to be consistent with the other equivalent methods. http://gerrit.cloudera.org:8080/#/c/15401/2/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/15401/2/src/kudu/tserver/ts_tablet_manager.cc@890 PS2, Line 890: std::function > nit: maybe add 'using std::function' and drop the namespace prefix here and Would rather not unless I did it across the board (i.e. plenty of other files refer to it as std::function). -- To view, visit http://gerrit.cloudera.org:8080/15401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2bd2d59809225e4cde7e273e95428478a282aa2d Gerrit-Change-Number: 15401 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 11 Mar 2020 22:46:07 +0000 Gerrit-HasComments: Yes
