Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15401 )
Change subject: threadpool: simplify Submit API ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/15401/4/src/kudu/util/threadpool-test.cc File src/kudu/util/threadpool-test.cc: http://gerrit.cloudera.org:8080/#/c/15401/4/src/kudu/util/threadpool-test.cc@475 PS4, Line 475: class SlowDestructorRunnable { nit: once dropping virtual for the destructor, maybe add final specifier for the class? https://en.cppreference.com/w/cpp/language/final Feel free to ignore. -- To view, visit http://gerrit.cloudera.org:8080/15401 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2bd2d59809225e4cde7e273e95428478a282aa2d Gerrit-Change-Number: 15401 Gerrit-PatchSet: 4 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 12 Mar 2020 01:32:45 +0000 Gerrit-HasComments: Yes
