Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15393 )

Change subject: [docker] Add an Impala quickstart image
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15393/4/docker/impala-entrypoint.sh
File docker/impala-entrypoint.sh:

http://gerrit.cloudera.org:8080/#/c/15393/4/docker/impala-entrypoint.sh@24
PS4, Line 24: set -e
> I am not sure what could fail in a bad or unclear way. Especially consideri
>From 'man bash':

                      pipefail
                              If  set,  the return value of a pipeline is the 
value of the
                              last (rightmost) command to exit with a non-zero 
status,  or
                              zero  if  all  commands  in  the pipeline exit 
successfully.
                              This option is disabled by default.


Try this with and without 'set -o pipefail'

-----

#!/bin/bash

set -e
#set -o pipefail

var=$(which ls | grep ls | sed "s:mega::")

echo "past the failure"

-----



--
To view, visit http://gerrit.cloudera.org:8080/15393
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d88bcb52f793c0fc83c4f84a9b56c5b961e58d5
Gerrit-Change-Number: 15393
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 12 Mar 2020 17:57:39 +0000
Gerrit-HasComments: Yes

Reply via email to