Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15393 )
Change subject: [docker] Add an Impala quickstart image ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/15393/4/docker/Dockerfile File docker/Dockerfile: http://gerrit.cloudera.org:8080/#/c/15393/4/docker/Dockerfile@356 PS4, Line 356: # Build Impala : RUN source bin/impala-config.sh \ : && ./buildall.sh -release -noclean -notests \ : && docker/setup_build_context.py Is this able to succeed outside of the internal cloudera network? I remember there were some issues with that some time ago. Are they gone at this point? Also, I've heard it's not possible to build Impala out-of-the-box anywhere except for Ubuntu 16.08. Is that still an issue? If yes, maybe add a verification step for the distro and the version to bail out earlier if it's not the desired Ubuntu 16.08 http://gerrit.cloudera.org:8080/#/c/15393/4/docker/Dockerfile@474 PS4, Line 474: nit: will this extra spacing end up into a too-long space in the result image's metadata? http://gerrit.cloudera.org:8080/#/c/15393/4/docker/Dockerfile@478 PS4, Line 478: $MAINTAINER What if MAINTAINER's value contains spaces? http://gerrit.cloudera.org:8080/#/c/15393/4/docker/Dockerfile@482 PS4, Line 482: $VCS_URL Does it work as expected if VCS_URL contains '#' or something like that? Maybe, wrap this into double quotes? -- To view, visit http://gerrit.cloudera.org:8080/15393 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d88bcb52f793c0fc83c4f84a9b56c5b961e58d5 Gerrit-Change-Number: 15393 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 11 Mar 2020 22:13:29 +0000 Gerrit-HasComments: Yes
