Hello Thomas Tauber-Marshall, Kudu Jenkins, Adar Dembo, Wenzhe Zhou, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15424 to look at the new patch set (#2). Change subject: [client] Add C++ API to accept BlockBloomFilter directly ...................................................................... [client] Add C++ API to accept BlockBloomFilter directly For performance reasons, ability to use its own allocator etc., callers may choose to supply BlockBloomFilter directly instead of using client::KuduBloomFilter. Case in point Impala. The allocator and BlockBloomFilter are accepted as Slice parameters that wrap the raw pointers. This API is marked Advanced/Unstable as supplying incorrect/incompatible parameters can lead to undefined results and it could change in future in backward incompatible manner. Change-Id: Iea85e3da8fe55f78e49a80439e6af723aa3d970b --- M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/predicate-test.cc M src/kudu/client/scan_predicate-internal.h M src/kudu/client/scan_predicate.cc 5 files changed, 317 insertions(+), 56 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/15424/2 -- To view, visit http://gerrit.cloudera.org:8080/15424 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Iea85e3da8fe55f78e49a80439e6af723aa3d970b Gerrit-Change-Number: 15424 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>