Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15424 )
Change subject: [client] Add C++ API to accept BlockBloomFilter directly ...................................................................... [client] Add C++ API to accept BlockBloomFilter directly For performance reasons, ability to use its own allocator etc., callers may choose to supply BlockBloomFilter directly instead of using client::KuduBloomFilter. Case in point Impala. The allocator and BlockBloomFilter are accepted as Slice parameters that wrap the raw pointers. This API is marked Advanced/Unstable as supplying incorrect/incompatible parameters can lead to undefined results and it could change in future in backward incompatible manner. Change-Id: Iea85e3da8fe55f78e49a80439e6af723aa3d970b Reviewed-on: http://gerrit.cloudera.org:8080/15424 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Kudu Jenkins Reviewed-by: Wenzhe Zhou <[email protected]> --- M src/kudu/client/client.cc M src/kudu/client/client.h M src/kudu/client/predicate-test.cc M src/kudu/client/scan_predicate-internal.h M src/kudu/client/scan_predicate.cc 5 files changed, 321 insertions(+), 56 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified Wenzhe Zhou: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/15424 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iea85e3da8fe55f78e49a80439e6af723aa3d970b Gerrit-Change-Number: 15424 Gerrit-PatchSet: 5 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
