Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15450 )
Change subject: [util] Minor changes in BlockBloomFilter requested by Impala ...................................................................... Patch Set 2: Verified+1 (1 comment) Overriding Jenkins, TSAN failure is a known flake. http://gerrit.cloudera.org:8080/#/c/15450/2/src/kudu/util/block_bloom_filter.cc File src/kudu/util/block_bloom_filter.cc: http://gerrit.cloudera.org:8080/#/c/15450/2/src/kudu/util/block_bloom_filter.cc@48 PS2, Line 48: // Flag used to initialize the static function pointers for the BlockBloomFilter class. : static std::once_flag g_init_func_ptrs_flag; > This flag is not accessed from outside this .cc file and don't see a need i Right, it's just more idiomatic for C++ to use an anonymous namespace (vs. static keyword, which is more of a C-ism). Oh, I misread L51 and thought it was an anonymous namespace; now I see why you don't want to introduce an entire new namespace block just for this variable. Makes sense. -- To view, visit http://gerrit.cloudera.org:8080/15450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5944f80f4c071ce787eded3f5b41d3bc56560cd0 Gerrit-Change-Number: 15450 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 17 Mar 2020 04:06:25 +0000 Gerrit-HasComments: Yes
