Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15450 )
Change subject: [util] Minor changes in BlockBloomFilter requested by Impala ...................................................................... [util] Minor changes in BlockBloomFilter requested by Impala 1) Do not include glog/logging.h and gflags/gflags.h in public header file for utilities like block_bloom_filter.h and hash_util.h as it causes problems with code-gen/IR in Impala. 2) Public OrEqualArray() static function in BlockBloomFilter to avoid a copy. This change forced using static function pointers that are initialized only once. Change-Id: I5944f80f4c071ce787eded3f5b41d3bc56560cd0 Reviewed-on: http://gerrit.cloudera.org:8080/15450 Tested-by: Adar Dembo <[email protected]> Reviewed-by: Adar Dembo <[email protected]> --- M src/kudu/util/block_bloom_filter-test.cc M src/kudu/util/block_bloom_filter.cc M src/kudu/util/block_bloom_filter.h M src/kudu/util/block_bloom_filter_avx2.cc M src/kudu/util/hash_util.h 5 files changed, 105 insertions(+), 35 deletions(-) Approvals: Adar Dembo: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/15450 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5944f80f4c071ce787eded3f5b41d3bc56560cd0 Gerrit-Change-Number: 15450 Gerrit-PatchSet: 3 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
