Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15435 )
Change subject: [ranger] validate the JAR file path of the subprocess ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/15435/5/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15435/5/src/kudu/ranger/ranger_client.cc@145 PS5, Line 145: FLAGS_ranger_jar_path Why not call GetJavaClasspath() here? Otherwise this validation might yield a false positive. -- To view, visit http://gerrit.cloudera.org:8080/15435 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d Gerrit-Change-Number: 15435 Gerrit-PatchSet: 5 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 18 Mar 2020 05:54:47 +0000 Gerrit-HasComments: Yes
