Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15435 )
Change subject: [ranger] validate the JAR file path of the subprocess ...................................................................... Patch Set 6: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/15435/6/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15435/6/src/kudu/ranger/ranger_client.cc@139 PS6, Line 139: } // anonymous namespace : : static bool ValidateRangerConfiguration() { nit: static functions and functions that are in an anonymous namespace serve the same purpose: they're unusable outside this translation unit. Could you standardize on one? -- To view, visit http://gerrit.cloudera.org:8080/15435 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I361689971dcd8dd74c13b90b61b922e7f7c7a88d Gerrit-Change-Number: 15435 Gerrit-PatchSet: 6 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 19 Mar 2020 02:41:15 +0000 Gerrit-HasComments: Yes
