Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15490 )
Change subject: tell IWYU to keep all inclusions of kudu/client/shared_ptr.h ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15490/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15490/1//COMMIT_MSG@10 PS1, Line 10: and IWYU thinks that's redundant with actual inclusions of : <memory> Didn't it change after removing 'IWYU pragma: export' from #include <memory> in kudu/client/shared_ptr.h ? -- To view, visit http://gerrit.cloudera.org:8080/15490 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic5ecd6b16542eb6b61e7f2b6c967048ab599ea93 Gerrit-Change-Number: 15490 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 19 Mar 2020 17:11:33 +0000 Gerrit-HasComments: Yes
