Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15490 )
Change subject: tell IWYU to keep all inclusions of kudu/client/shared_ptr.h ...................................................................... tell IWYU to keep all inclusions of kudu/client/shared_ptr.h When IWYU is run with libc++, this header becomes yet another way to include <memory>, and IWYU thinks that's redundant with actual inclusions of <memory>. That's true in the context of the IWYU run, but not when actually building Kudu. Change-Id: Ic5ecd6b16542eb6b61e7f2b6c967048ab599ea93 Reviewed-on: http://gerrit.cloudera.org:8080/15490 Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Adar Dembo <[email protected]> --- M src/kudu/benchmarks/tpch/rpc_line_item_dao.h M src/kudu/client/batcher.cc M src/kudu/client/batcher.h M src/kudu/client/client-test-util.h M src/kudu/client/client-test.cc M src/kudu/client/partitioner-internal.h M src/kudu/client/predicate-test.cc M src/kudu/client/scan_token-internal.cc M src/kudu/client/scan_token-test.cc M src/kudu/client/scanner-internal.h M src/kudu/client/session-internal.h M src/kudu/client/shared_ptr.h M src/kudu/client/table-internal.h M src/kudu/integration-tests/all_types-itest.cc M src/kudu/integration-tests/alter_table-randomized-test.cc M src/kudu/integration-tests/alter_table-test.cc M src/kudu/integration-tests/auth_token_expire-itest.cc M src/kudu/integration-tests/authz_token-itest.cc M src/kudu/integration-tests/catalog_manager_tsk-itest.cc M src/kudu/integration-tests/client-negotiation-failover-itest.cc M src/kudu/integration-tests/client-stress-test.cc M src/kudu/integration-tests/client_failover-itest.cc M src/kudu/integration-tests/cluster_verifier.cc M src/kudu/integration-tests/consistency-itest.cc M src/kudu/integration-tests/create-table-itest.cc M src/kudu/integration-tests/create-table-stress-test.cc M src/kudu/integration-tests/decimal-itest.cc M src/kudu/integration-tests/delete_table-itest.cc M src/kudu/integration-tests/disk_failure-itest.cc M src/kudu/integration-tests/external_mini_cluster-itest-base.h M src/kudu/integration-tests/flex_partitioning-itest.cc M src/kudu/integration-tests/full_stack-insert-scan-test.cc M src/kudu/integration-tests/fuzz-itest.cc M src/kudu/integration-tests/heavy-update-compaction-itest.cc M src/kudu/integration-tests/hms_itest-base.cc M src/kudu/integration-tests/internal_mini_cluster-itest-base.h M src/kudu/integration-tests/linked_list-test.cc M src/kudu/integration-tests/location_assignment-itest.cc M src/kudu/integration-tests/master-stress-test.cc M src/kudu/integration-tests/master_cert_authority-itest.cc M src/kudu/integration-tests/master_failover-itest.cc M src/kudu/integration-tests/master_hms-itest.cc M src/kudu/integration-tests/master_migration-itest.cc M src/kudu/integration-tests/master_replication-itest.cc M src/kudu/integration-tests/master_sentry-itest.cc M src/kudu/integration-tests/open-readonly-fs-itest.cc M src/kudu/integration-tests/raft_consensus-itest-base.cc M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc M src/kudu/integration-tests/security-faults-itest.cc M src/kudu/integration-tests/security-itest.cc M src/kudu/integration-tests/security-unknown-tsk-itest.cc M src/kudu/integration-tests/stop_tablet-itest.cc M src/kudu/integration-tests/tablet_copy-itest.cc M src/kudu/integration-tests/tablet_history_gc-itest.cc M src/kudu/integration-tests/tablet_server_quiescing-itest.cc M src/kudu/integration-tests/test_workload.h M src/kudu/integration-tests/ts_itest-base.h M src/kudu/integration-tests/ts_recovery-itest.cc M src/kudu/integration-tests/ts_sentry-itest.cc M src/kudu/integration-tests/ts_tablet_manager-itest.cc M src/kudu/integration-tests/update_scan_delta_compact-test.cc M src/kudu/integration-tests/varchar-itest.cc M src/kudu/integration-tests/version_migration-test.cc M src/kudu/integration-tests/write_throttling-itest.cc M src/kudu/mini-cluster/external_mini_cluster.h M src/kudu/mini-cluster/internal_mini_cluster.h M src/kudu/mini-cluster/mini_cluster.h M src/kudu/tools/create-table-tool-test.cc M src/kudu/tools/ksck_remote-test.cc M src/kudu/tools/ksck_remote.h M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/rebalancer_tool-test.cc M src/kudu/tools/rebalancer_tool.h M src/kudu/tools/table_scanner.h M src/kudu/tools/tool_action_common.cc M src/kudu/tools/tool_action_common.h M src/kudu/tools/tool_action_hms.cc M src/kudu/tools/tool_action_perf.cc M src/kudu/tools/tool_action_table.cc M src/kudu/tools/tool_action_tablet.cc M src/kudu/tools/tool_replica_util.cc M src/kudu/tools/tool_replica_util.h 84 files changed, 97 insertions(+), 90 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Adar Dembo: Verified -- To view, visit http://gerrit.cloudera.org:8080/15490 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic5ecd6b16542eb6b61e7f2b6c967048ab599ea93 Gerrit-Change-Number: 15490 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]>
