Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15504 )
Change subject: [thirdparty] python3 is good for building LLVM ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/15504/3/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/15504/3/thirdparty/build-definitions.sh@160 PS3, Line 160: local python_ver_str="$(python3 -V 2>&1)" > Is python 3 installed on all the OSs we support? Including Centos 6? whoops, that's a bug -- I overdid optimizing it. Returning back to PS2. http://gerrit.cloudera.org:8080/#/c/15504/3/thirdparty/vars.sh File thirdparty/vars.sh: http://gerrit.cloudera.org:8080/#/c/15504/3/thirdparty/vars.sh@156 PS3, Line 156: PYTHON_VERSION=2.7.13 > Should we put python 3 in thirdparty or remove this all together? By default, python is not included into CentOS 8.1 minimal installation. So, I'm hesitant to remove it because kudu thirdparty build would break in that case. I'm not sure we want to build python3 as part of thirdparty -- it's heavier and takes more time to compile. -- To view, visit http://gerrit.cloudera.org:8080/15504 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9e01da29595af5d1d7ed78e1794325df2dacf55 Gerrit-Change-Number: 15504 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 20 Mar 2020 00:47:26 +0000 Gerrit-HasComments: Yes
