Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15504 )
Change subject: [thirdparty] python3 is good for building LLVM ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/15504/5/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/15504/5/thirdparty/build-definitions.sh@163 PS5, Line 163: elif [[ $(python2 -V 2>&1) =~ "Python 2.7." ]]; then > You want to prefer a 'python2' (e.g. 2.7.x) binary over a 'python' (e.g. 3. Good catch. Generally, it doesn't matter, but I agree that for consistency it's better to prefer python3. -- To view, visit http://gerrit.cloudera.org:8080/15504 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9e01da29595af5d1d7ed78e1794325df2dacf55 Gerrit-Change-Number: 15504 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 20 Mar 2020 04:14:52 +0000 Gerrit-HasComments: Yes
