Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15501 )
Change subject: client: avoid an extra construction of ColumnSchema ...................................................................... client: avoid an extra construction of ColumnSchema KuduSchema::Column() was making an unnecessary copy of a ColumnSchema object, when it instead could just use a local reference. This showed up in my TSBS benchmark as an easily-addressed waste of CPU cycles. Change-Id: I695d760837fb529a549e83b5385a1df79f358697 Reviewed-on: http://gerrit.cloudera.org:8080/15501 Reviewed-by: Andrew Wong <[email protected]> Reviewed-by: Bankim Bhavsar <[email protected]> Reviewed-by: Adar Dembo <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Todd Lipcon <[email protected]> --- M src/kudu/client/schema.cc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Andrew Wong: Looks good to me, approved Bankim Bhavsar: Looks good to me, but someone else must approve Adar Dembo: Looks good to me, approved Alexey Serbin: Looks good to me, approved Todd Lipcon: Verified -- To view, visit http://gerrit.cloudera.org:8080/15501 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I695d760837fb529a549e83b5385a1df79f358697 Gerrit-Change-Number: 15501 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]>
