Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15145 )
Change subject: KUDU-1625: background op to GC ancient, fully deleted rowsets ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/15145/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15145/8//COMMIT_MSG@9 PS8, Line 9: an Nit: a http://gerrit.cloudera.org:8080/#/c/15145/7/src/kudu/integration-tests/tablet_history_gc-itest.cc File src/kudu/integration-tests/tablet_history_gc-itest.cc: http://gerrit.cloudera.org:8080/#/c/15145/7/src/kudu/integration-tests/tablet_history_gc-itest.cc@308 PS7, Line 308: shared_ptr<KuduSession> session = client_->NewSession(); > Done Thanks. I think it was cargo culted from the other tests here, so feel free to fix them too if you're building a new revision. http://gerrit.cloudera.org:8080/#/c/15145/7/src/kudu/integration-tests/tablet_history_gc-itest.cc@335 PS7, Line 335: ASSERT_OK(Env::Default()->GetFileSizeOnDiskRecursively(cluster_->GetTabletServerFsRoot(0), > Went with ASSERT_EVENTUALLY. I presume compaction-test was written before t Probably, yeah. Would be good to doc why we ASSERT_EVENTUALLY though, and also on L330. -- To view, visit http://gerrit.cloudera.org:8080/15145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I696e2a29ea52ad4e54801b495c322bc371787124 Gerrit-Change-Number: 15145 Gerrit-PatchSet: 8 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Fri, 20 Mar 2020 22:23:28 +0000 Gerrit-HasComments: Yes
