Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15145 )
Change subject: KUDU-1625: background op to GC ancient, fully deleted rowsets ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/15145/5/src/kudu/integration-tests/tablet_history_gc-itest.cc File src/kudu/integration-tests/tablet_history_gc-itest.cc: http://gerrit.cloudera.org:8080/#/c/15145/5/src/kudu/integration-tests/tablet_history_gc-itest.cc@118 PS5, Line 118: Status InsertRowsToTable(KuduTable* table, KuduSession* session, > warning: method 'InsertRowsToTable' can be made static [readability-convert Done http://gerrit.cloudera.org:8080/#/c/15145/5/src/kudu/tablet/tablet_replica-test.cc File src/kudu/tablet/tablet_replica-test.cc: http://gerrit.cloudera.org:8080/#/c/15145/5/src/kudu/tablet/tablet_replica-test.cc@810 PS5, Line 810: tablet->GetMetricEntity(), Callback<uint64_t(void)>()); > error: no viable conversion from 'Callback<uint64_t ()>' (aka 'Callback<uns Done http://gerrit.cloudera.org:8080/#/c/15145/5/src/kudu/tablet/tablet_replica-test.cc@836 PS5, Line 836: tablet->GetMetricEntity(), Callback<uint64_t(void)>()); > error: no viable conversion from 'Callback<uint64_t ()>' (aka 'Callback<uns Done -- To view, visit http://gerrit.cloudera.org:8080/15145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I696e2a29ea52ad4e54801b495c322bc371787124 Gerrit-Change-Number: 15145 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Fri, 20 Mar 2020 00:12:12 +0000 Gerrit-HasComments: Yes
