Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15374 )
Change subject: KUDU-3079 Add MiniPostgres ...................................................................... Patch Set 24: (2 comments) http://gerrit.cloudera.org:8080/#/c/15374/24/src/kudu/postgres/mini_postgres-test.cc File src/kudu/postgres/mini_postgres-test.cc: http://gerrit.cloudera.org:8080/#/c/15374/24/src/kudu/postgres/mini_postgres-test.cc@48 PS24, Line 48: ASSERT_OK(postgres_.Stop()); : ASSERT_OK(postgres_.Start()); Wasn't sure why we're restarting here until I read the test name. Maybe add some comments? Also maybe CreateDb() before restarting, and then restart, and then CreateDb() a different database? Then we get coverage both with and without persistence. http://gerrit.cloudera.org:8080/#/c/15374/24/src/kudu/util/subprocess.cc File src/kudu/util/subprocess.cc: http://gerrit.cloudera.org:8080/#/c/15374/24/src/kudu/util/subprocess.cc@563 PS24, Line 563: exit_status nit: log the info_str too? -- To view, visit http://gerrit.cloudera.org:8080/15374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba40126aa60e0ecbc5ae10cc1328493194c345bc Gerrit-Change-Number: 15374 Gerrit-PatchSet: 24 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 23 Mar 2020 07:55:00 +0000 Gerrit-HasComments: Yes
