Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15374 )
Change subject: KUDU-3079 Add MiniPostgres ...................................................................... Patch Set 26: (2 comments) http://gerrit.cloudera.org:8080/#/c/15374/25/src/kudu/postgres/mini_postgres-test.cc File src/kudu/postgres/mini_postgres-test.cc: http://gerrit.cloudera.org:8080/#/c/15374/25/src/kudu/postgres/mini_postgres-test.cc@49 PS25, Line 49: Restart > Nit: Restart Done http://gerrit.cloudera.org:8080/#/c/15374/21/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/15374/21/thirdparty/build-definitions.sh@1034 PS21, Line 1034: # We don't need extra features like readline and zlib so so let's just > No, it's fine as-is; just wanted to better understand the effects. Done -- To view, visit http://gerrit.cloudera.org:8080/15374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba40126aa60e0ecbc5ae10cc1328493194c345bc Gerrit-Change-Number: 15374 Gerrit-PatchSet: 26 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 23 Mar 2020 20:52:13 +0000 Gerrit-HasComments: Yes
