Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15483 )
Change subject: KUDU-3079 Add MiniRanger ...................................................................... Patch Set 39: (4 comments) http://gerrit.cloudera.org:8080/#/c/15483/39/build-support/run_dist_test.py File build-support/run_dist_test.py: http://gerrit.cloudera.org:8080/#/c/15483/39/build-support/run_dist_test.py@172 PS39, Line 172: os.path.join(bin_path, "postgresql.jar")) Got some trailing whitespace here. http://gerrit.cloudera.org:8080/#/c/15483/39/build-support/run_dist_test.py@178 PS39, Line 178: # Create symlink for Ranger default config directory. Hmm, when dist-test copied the local bundle and sent it to the remote slave, didn't it convert the symlink into a real file? Or did it not copy this at all? http://gerrit.cloudera.org:8080/#/c/15483/39/src/kudu/ranger/mini_ranger-test.cc File src/kudu/ranger/mini_ranger-test.cc: http://gerrit.cloudera.org:8080/#/c/15483/39/src/kudu/ranger/mini_ranger-test.cc@74 PS39, Line 74: const std::string kExpectedError = "Another policy already exists for matching resource"; Nit: add a using for this. http://gerrit.cloudera.org:8080/#/c/15483/22/src/kudu/ranger/mini_ranger.cc File src/kudu/ranger/mini_ranger.cc: http://gerrit.cloudera.org:8080/#/c/15483/22/src/kudu/ranger/mini_ranger.cc@150 PS22, Line 150: return db_setup.WaitAndCheckExitCode(); > Around 8 seconds. I don't think Postgres is the bottleneck here though. Als OK, future work then. -- To view, visit http://gerrit.cloudera.org:8080/15483 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15ab1eb8abe71c074c26b286073442882e101bc6 Gerrit-Change-Number: 15483 Gerrit-PatchSet: 39 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 23 Mar 2020 20:40:38 +0000 Gerrit-HasComments: Yes
