Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15483 )
Change subject: KUDU-3079 Add MiniRanger ...................................................................... Patch Set 40: (4 comments) http://gerrit.cloudera.org:8080/#/c/15483/39/build-support/run_dist_test.py File build-support/run_dist_test.py: http://gerrit.cloudera.org:8080/#/c/15483/39/build-support/run_dist_test.py@172 PS39, Line 172: os.path.join(bin_path, "postgresql.jar")) > Got some trailing whitespace here. Done http://gerrit.cloudera.org:8080/#/c/15483/39/build-support/run_dist_test.py@178 PS39, Line 178: env['LD_LIBRARY_PATH'] = ":".join( > Hmm, when dist-test copied the local bundle and sent it to the remote slave TBH that's kinda what I'm trying to figure out. I tried running dist-test manually for this test which worked fine, the issue is definitely with the thirdparty libs not being in place where the MiniRanger expects them to be. Unfortunately I can't think of a way to test/fix this other than trying out different ways by changing these and pushing to gerrit. http://gerrit.cloudera.org:8080/#/c/15483/39/src/kudu/ranger/mini_ranger-test.cc File src/kudu/ranger/mini_ranger-test.cc: http://gerrit.cloudera.org:8080/#/c/15483/39/src/kudu/ranger/mini_ranger-test.cc@74 PS39, Line 74: ASSERT_OK(ranger_.Start()); > Nit: add a using for this. Done http://gerrit.cloudera.org:8080/#/c/15483/22/src/kudu/ranger/mini_ranger.cc File src/kudu/ranger/mini_ranger.cc: http://gerrit.cloudera.org:8080/#/c/15483/22/src/kudu/ranger/mini_ranger.cc@150 PS22, Line 150: return db_setup.WaitAndCheckExitCode(); > OK, future work then. Done -- To view, visit http://gerrit.cloudera.org:8080/15483 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15ab1eb8abe71c074c26b286073442882e101bc6 Gerrit-Change-Number: 15483 Gerrit-PatchSet: 40 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 23 Mar 2020 20:54:47 +0000 Gerrit-HasComments: Yes
