Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15483 )
Change subject: KUDU-3079 Add MiniRanger ...................................................................... Patch Set 46: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/15483/46//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15483/46//COMMIT_MSG@39 PS46, Line 39: Env nit: add a period http://gerrit.cloudera.org:8080/#/c/15483/46/src/kudu/ranger/mini_ranger.cc File src/kudu/ranger/mini_ranger.cc: http://gerrit.cloudera.org:8080/#/c/15483/46/src/kudu/ranger/mini_ranger.cc@151 PS46, Line 151: Startin nit: Starting http://gerrit.cloudera.org:8080/#/c/15483/46/src/kudu/ranger/mini_ranger.cc@288 PS46, Line 288: : LOG(INFO) << "Created Kudu service"; Seems this should be put into CreateKuduService() instead -- To view, visit http://gerrit.cloudera.org:8080/15483 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15ab1eb8abe71c074c26b286073442882e101bc6 Gerrit-Change-Number: 15483 Gerrit-PatchSet: 46 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 24 Mar 2020 21:08:13 +0000 Gerrit-HasComments: Yes
