Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15483 )
Change subject: KUDU-3079 Add MiniRanger ...................................................................... Patch Set 47: (3 comments) > Patch Set 45: > > Something we'll want to address soon-ish: I ran mini_ranger-test 50 times and > saw two failures with the following error to start Postgres: > > ../../src/kudu/ranger/mini_ranger-test.cc:74: Failure > Failed > Bad status: Runtime error: failed to start Postgres: /usr/bin/lsof: process > exited with non-zero status 1 > I0324 03:44:25.806879 348 mini_ranger.cc:60] Stopping Ranger... > F0324 03:44:25.806896 348 subprocess.cc:646] Sub-process is not running > *** Check failure stack trace: *** > *** Aborted at 1585021465 (unix time) try "date -d @1585021465" if you are > using GNU date *** > PC: @ 0x7f40050adc37 gsignal > *** SIGABRT (@0x3e80000015c) received by PID 348 (TID 0x7f400d47d880) from > PID 348; stack trace: *** > @ 0x7f4005450330 (unknown) at ??:0 > @ 0x7f40050adc37 gsignal at ??:0 > @ 0x7f40050b1028 abort at ??:0 > @ 0x7f4006bd1a19 google::logging_fail() at ??:0 > @ 0x7f4006bd330d google::LogMessage::Fail() at ??:0 > @ 0x7f4006bd51cd google::LogMessage::SendToLog() at ??:0 > @ 0x7f4006bd2e49 google::LogMessage::Flush() at ??:0 > @ 0x7f4006bd30a1 google::LogMessage::~LogMessage() at ??:0 > @ 0x7f4009f5d38f kudu::Subprocess::KillAndWait() at ??:0 > @ 0x7f400ce6605d kudu::ranger::MiniRanger::Stop() at ??:0 > @ 0x7f400ce65eaf kudu::ranger::MiniRanger::~MiniRanger() at ??:0 > @ 0x41538a kudu::ranger::MiniRangerTest::~MiniRangerTest() at > /data/8/awong/Repositories/kudu/build/debug/../../src/kudu/ranger/mini_ranger-test.cc:36 > @ 0x41a3ae > kudu::ranger::MiniRangerTest_TestGrantSamePrivilegeAfterRestart_Test::~MiniRangerTest_TestGrantSamePrivilegeAfterRestart_Test() > at > /data/8/awong/Repositories/kudu/build/debug/../../src/kudu/ranger/mini_ranger-test.cc:60 > @ 0x41a3de > kudu::ranger::MiniRangerTest_TestGrantSamePrivilegeAfterRestart_Test::~MiniRangerTest_TestGrantSamePrivilegeAfterRestart_Test() > at > /data/8/awong/Repositories/kudu/build/debug/../../src/kudu/ranger/mini_ranger-test.cc:60 > @ 0x7f400a7e6b98 > testing::internal::HandleExceptionsInMethodIfSupported<>() at ??:0 > @ 0x7f400a7d42b5 testing::TestInfo::Run() at ??:0 > @ 0x7f400a7d43d5 testing::TestCase::Run() at ??:0 > @ 0x7f400a7daed8 testing::internal::UnitTestImpl::RunAllTests() at > ??:0 > @ 0x7f400a7e70a8 > testing::internal::HandleExceptionsInMethodIfSupported<>() at ??:0 > @ 0x7f400a7d44ad testing::UnitTest::Run() at ??:0 > @ 0x7f400d07bf5f RUN_ALL_TESTS() at ??:0 > @ 0x7f400d079d70 main at ??:0 > @ 0x7f4005098f45 __libc_start_main at ??:0 > @ 0x412d59 (unknown) at ??:? thanks for the heads up, fixed it, ran this test suite with 100 iterations with no failures. http://gerrit.cloudera.org:8080/#/c/15483/46//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15483/46//COMMIT_MSG@39 PS46, Line 39: Env > nit: add a period Done http://gerrit.cloudera.org:8080/#/c/15483/46/src/kudu/ranger/mini_ranger.cc File src/kudu/ranger/mini_ranger.cc: http://gerrit.cloudera.org:8080/#/c/15483/46/src/kudu/ranger/mini_ranger.cc@151 PS46, Line 151: Startin > nit: Starting Done http://gerrit.cloudera.org:8080/#/c/15483/46/src/kudu/ranger/mini_ranger.cc@288 PS46, Line 288: "Failed to add policy"); : return Status::OK(); > Seems this should be put into CreateKuduService() instead Done -- To view, visit http://gerrit.cloudera.org:8080/15483 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15ab1eb8abe71c074c26b286073442882e101bc6 Gerrit-Change-Number: 15483 Gerrit-PatchSet: 47 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 24 Mar 2020 21:49:17 +0000 Gerrit-HasComments: Yes
