Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15492 )

Change subject: iwyu: standardize on libc++
......................................................................


Patch Set 10:

> Looks good to me and I verified it works fine on CentOS8.
 >
 > However, there are issues when building the code on macOS with the
 > clang from the third-party.  I think that's might be something with
 > my environment and not exactly related to this patch.  I'll try to
 > clarify on that.

Meanwhile, I think this patch is good to go.  Thank you for implementing this!


--
To view, visit http://gerrit.cloudera.org:8080/15492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic807745271642b3d5d80ea0ad9bc413bdb0e34b5
Gerrit-Change-Number: 15492
Gerrit-PatchSet: 10
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Comment-Date: Thu, 26 Mar 2020 00:03:17 +0000
Gerrit-HasComments: No

Reply via email to