Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15492 )
Change subject: iwyu: standardize on libc++ ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/15492/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15492/5//COMMIT_MSG@12 PS5, Line 12: Ubuntu 14.10 VM > Not sure whether it's worth noting it here, but it also works for CentOS 6. The recommendations you got on CentOS 6.6 don't always match that of Ubuntu 14.10. In particular, I've seen CentOS 6.6 tell me to add/remove either <utility> or <algorithm>, and then Ubuntu 14.10 asks me to undo it. http://gerrit.cloudera.org:8080/#/c/15492/5/src/kudu/util/thread.cc File src/kudu/util/thread.cc: http://gerrit.cloudera.org:8080/#/c/15492/5/src/kudu/util/thread.cc@122 PS5, Line 122: rusage > I'm curious, what is the significance of this change? Was it necessary to Unrelated to IWYU; just consistency with the rest of the codebase. I ended up moving it into the next patch anyway. -- To view, visit http://gerrit.cloudera.org:8080/15492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic807745271642b3d5d80ea0ad9bc413bdb0e34b5 Gerrit-Change-Number: 15492 Gerrit-PatchSet: 7 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 24 Mar 2020 17:18:39 +0000 Gerrit-HasComments: Yes
