Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15601 )
Change subject: KUDU-3081 Add Kerberos support to MiniRanger ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/15601/4/src/kudu/ranger/mini_ranger.cc File src/kudu/ranger/mini_ranger.cc: http://gerrit.cloudera.org:8080/#/c/15601/4/src/kudu/ranger/mini_ranger.cc@206 PS4, Line 206: string krb5_config = getenv("KRB5_CONFIG"); > in this case this is not as important as in RangerClient, but I still think Isn't it important for the KRB5_CONFIG used by MiniRanger to be the one from MiniKdc? Likewise, for the RangerClient, isn't it important for our tests that we use the environment variables produced by MiniKdc? http://gerrit.cloudera.org:8080/#/c/15601/6/src/kudu/ranger/mini_ranger.cc File src/kudu/ranger/mini_ranger.cc: http://gerrit.cloudera.org:8080/#/c/15601/6/src/kudu/ranger/mini_ranger.cc@107 PS6, Line 107: "127.0.0.1" nit: no longer needs to be configurable? Same below? http://gerrit.cloudera.org:8080/#/c/15601/4/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15601/4/src/kudu/ranger/ranger_client.cc@195 PS4, Line 195: string krb5_config = getenv("KRB5_CONFIG"); > KRB5_CONFIG is a standard env var used to set the location of krb5.conf if Alternatively, we can expose a flag that, if set, will be used (e.g. in an EMC), and if not, will evaluate to getenv(KRB5_CONFIG). http://gerrit.cloudera.org:8080/#/c/15601/6/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15601/6/src/kudu/ranger/ranger_client.cc@222 PS6, Line 222: java_path() nit: make a local var and call once? -- To view, visit http://gerrit.cloudera.org:8080/15601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32118780ad912791fe5e371004345428b6459549 Gerrit-Change-Number: 15601 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 31 Mar 2020 22:21:09 +0000 Gerrit-HasComments: Yes
