Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15601 )
Change subject: KUDU-3081 Add Kerberos support to MiniRanger ...................................................................... Patch Set 10: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/15601/3/src/kudu/integration-tests/master_sentry-itest.cc File src/kudu/integration-tests/master_sentry-itest.cc: http://gerrit.cloudera.org:8080/#/c/15601/3/src/kudu/integration-tests/master_sentry-itest.cc@375 PS3, Line 375: void SetUp() override { > I believe that's a red herring, the same WARN appeared when the test passed I think using NullGroupsMapping is good for now, but eventually we would want to test policy granting associate with groups. http://gerrit.cloudera.org:8080/#/c/15601/10/src/kudu/ranger/mini_ranger.h File src/kudu/ranger/mini_ranger.h: http://gerrit.cloudera.org:8080/#/c/15601/10/src/kudu/ranger/mini_ranger.h@177 PS10, Line 177: uint32_t policy_poll_interval_ms_ = 200; nit: add a comment to explain what is policy_poll_interval_ms for? And why default to 200. http://gerrit.cloudera.org:8080/#/c/15601/10/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15601/10/src/kudu/ranger/ranger_client.cc@49 PS10, Line 49: , Can you add an example such as 'e.g. java'? http://gerrit.cloudera.org:8080/#/c/15601/10/src/kudu/ranger/ranger_client.cc@51 PS10, Line 51: d."); Can you comment on if $JAVA_HOME is not found? -- To view, visit http://gerrit.cloudera.org:8080/15601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32118780ad912791fe5e371004345428b6459549 Gerrit-Change-Number: 15601 Gerrit-PatchSet: 10 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 01 Apr 2020 22:08:33 +0000 Gerrit-HasComments: Yes
